Fix memory corruption caused by GlyphExtVertexSerializer#760
Merged
dima-dencep merged 1 commit intoAsek3:1.20.1-newfrom Jan 28, 2025
Merged
Fix memory corruption caused by GlyphExtVertexSerializer#760dima-dencep merged 1 commit intoAsek3:1.20.1-newfrom
dima-dencep merged 1 commit intoAsek3:1.20.1-newfrom
Conversation
Collaborator
|
Thanks ❤️ |
KostromDan
pushed a commit
to KostromDan/Mekalus
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Iris 1.7.x implementation of
GlyphExtVertexSerializerperforms out-of-bounds memory reads & writes when extending the vertex data. This leads to unpredictable behavior including consistent JVM native crashes on some platforms.There are several problems in the original code:
While investigating this problem, I determined the bug was quietly fixed upstream in this Iris commit for 1.8.0-beta.1. The fix does not appear to have been backported to any 1.7.x releases; as such, previous releases of Iris for Fabric are likely also affected.
I have confirmed, through testing, that a certain class of JVM crashes appear to be resolved by this change.