Skip to content

Fix inserting task at top/bottom of project #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apiology wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix inserting task at top/bottom of project #113

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a4bebc
Fix inserting task at top/bottom of project
Jun 18, 2017
e0f5a5c
Fix nil issue with set_parent()
Oct 2, 2017
8bae32b
Fix params included
Oct 2, 2017
4e91c39
Merge github.com:Asana/ruby-asana into insert_before_after
vinceatbluelabs Aug 28, 2019
0648d39
Allow parent to be set to nil in Task#set_parent()
vinceatbluelabs Aug 30, 2019
5200cbc
Merge remote-tracking branch 'upstream/master' into insert_before_after
apiology Sep 26, 2020
3018224
Merge remote-tracking branch 'origin/master' into insert_before_after
apiology Feb 9, 2021
4183f6c
Merge remote-tracking branch 'origin/master' into insert_before_after
apiology Jul 9, 2021
a6cc5ff
Merge branch 'Asana:master' into insert_before_after
apiology Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/asana/resources/task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ def projects(per_page: 20, options: {})
#
# Returns an empty data block.
#

# project - [Gid] The project to add the task to.
# insert_after - [Gid] A task in the project to insert the task after, or `null` to
# insert at the beginning of the list.
Expand All @@ -393,8 +394,10 @@ def projects(per_page: 20, options: {})
#
# options - [Hash] the request I/O options.
# data - [Hash] the attributes to post.
def add_project(project: required("project"), insert_after: nil, insert_before: nil, section: nil, options: {}, **data)
with_params = data.merge(project: project, insert_after: insert_after, insert_before: insert_before, section: section).reject { |_,v| v.nil? || Array(v).empty? }
def add_project(project: required("project"), insert_after: :not_provided, insert_before: :not_provided, section: nil, options: {}, **data)
with_params = data.merge(project: project, insert_after: insert_after, insert_before: insert_before, section: section).reject { |_,v| v.nil? || Array(v).empty? || v == :not_provided }
with_params[:insert_after] = nil if insert_after.nil?
with_params[:insert_before] = nil if insert_before.nil?
client.post("/tasks/#{gid}/addProject", body: with_params, options: options) && true
end

Expand Down Expand Up @@ -475,6 +478,7 @@ def add_subtask(options: {}, **data)
# data - [Hash] the attributes to post.
def set_parent(parent: required("parent"), insert_after: nil, insert_before: nil, options: {}, **data)
with_params = data.merge(parent: parent, insert_after: insert_after, insert_before: insert_before).reject { |_,v| v.nil? || Array(v).empty? }
with_params[:parent] = nil if parent.nil?
client.post("/tasks/#{gid}/setParent", body: with_params, options: options) && true
end

Expand Down