Skip to content

Replace xule locating code with plugin import #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
austinmatherne-wk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace xule locating code with plugin import #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions validate/XuleInterface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,23 +292,14 @@ def getXulePlugin(cntlr):
"""
global _xule_plugin_info, _incompatible_plugin, xulePluginDoesNotExist
if _xule_plugin_info is None and not xulePluginDoesNotExist:
for plugin_name, plugin_info in PluginManager.modulePluginInfos.items():
for plugin_info in PluginManager.modulePluginInfos.values():
moduleUrl = plugin_info.get('moduleURL')
if moduleUrl == 'xule':
_xule_plugin_info = plugin_info
elif DQC_plugin_url_pattern.match(moduleUrl):
_incompatible_plugin = moduleUrl
cntlr.addToLog(_("EDGAR is not compatible with the DQC.py plugin, please remove the DQC.py plugin. The EDGAR plugin directly manages running of to run DQC rules."),
messageCode="arelle.incompatibleRulePlugin")
if _xule_plugin_info is None:
# attempt to find xule plugi
for path, childDirs, files in os.walk(_plugin_dir):
if path.endswith(os.sep + "xule") and childDirs in ([], ["__pycache__"]) and "__init__.py" in files:
_xule_plugin_info = PluginManager.moduleModuleInfo(moduleURL=path)
PluginManager.loadModule(_xule_plugin_info)
PluginManager.pluginConfigChanged = False # don't save this change
_xule_plugin_info = PluginManager.modulePluginInfos[_xule_plugin_info["name"]]
break
if _xule_plugin_info is None and not xulePluginDoesNotExist:
cntlr.addToLog(_("Xule plugin is not loaded. Xule plugin is required to run DQC rules. This plugin should be automatically loaded."),
messageCode="arelle.xulePluginNotLoaded")
Expand Down
2 changes: 1 addition & 1 deletion validate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ def json(self): # stringify un-jsonable attributes
'version': '1.25.2', # SEC EDGAR release 25.2
'description': '''EFM Validation.''',
'license': 'Apache-2',
'import': ('EDGAR/transform',), # SEC inline can use SEC transformations
'import': ('EDGAR/transform', 'xule'), # SEC inline can use SEC transformations
'author': authorLabel,
'copyright': copyrightLabel,
'aliases': ('validate/EFM', ),
Expand Down