Update server.js #9
Conversation
There was a problem hiding this comment.
TLDR: this PR looks rushed to me and shows a lack of attention/effort. It is also just plain wrong. I want to see clean, well-thought out, and thoroughly tested code for the next one. Keep reading to see how to do that.
This code is wrong. All this does is send a socket event to every single user, and all this socket event does is re-render a few pages like the event stats page when a user creates an event -- this event should only fire when a user creates an event.
The function that needs to be used is sendNotifs() defined within helperMethods.js. Read how it's used elsewhere in the code and TEST YOUR PR prior to submitting so that we don't end up w/ faulty backend code like this.
TO TEST: try creating an event locally via the route and start off by only sending yourself the notifications. See if this works and then delete the test event from DB. Additionally, try printing out the expo notification tokens of every user in the DB to make sure those are loaded properly.
No description provided.