Skip to content

Conversation

@Samuelteal33
Copy link

Updated the below to allow for Recipients to receive message upon receipt of payment:

Updated Pay Command to send recipient a message when payment is completed so that they are informed of the payment.

Updated Deposit Command to send recipient a message when payment is completed by the server/admin such as in /eco give commands.

Updated TranslationHandler to allow for the parsing of these messages to the recipients.

Updated Translation.yml to allow for customization of the recipient messages under the commands Pay and Deposit.

Updated translations.yml to support new message for the Pay and Deposit commands for recipients to receive a message when receiving a reward via /pay or /deposit or /eco give.
Updated command file to support sending message to recipient on pay command to inform them that another player has sent them an amount of currency
Updated to support sending a message to recipients that they have received a reward either via /deposit or /give or any variant of the two with /eco in front.
Updated TranslationHandler to allow parsing of the recipient messages from Deposit/Give and from Pay commands.
@lokka30 lokka30 self-requested a review September 3, 2025 10:54
@lokka30 lokka30 added effort: medium This will require a normal amount of work relative to other issues priority: medium This should be resolved in the near future state: in progress Work is currently in progress to resolve this type: feature Requests a new or improved feature platform: bukkit Affects the Bukkit platform labels Sep 3, 2025
@lokka30 lokka30 moved this to In Queue in Polyconomy Priorities Sep 3, 2025
@lokka30
Copy link
Member

lokka30 commented Sep 3, 2025

Awesome work - thanks so much. I'll review this as soon as I have some time off - hopefully this Sunday. If all goes well (by the sounds of your approach in the description, highly likely!) then I'll merge this in and make sure to make sure you're credited for your work.

I also had a thought that it would be worth making the 'money received by administrative /eco command' message type to be toggleable, something I'll work on after merging. I will need to check the default behaviour of Essentials economy and try mirror that, and have the option for users to enable/disable it.

@lokka30 lokka30 linked an issue Sep 3, 2025 that may be closed by this pull request
@lokka30
Copy link
Member

lokka30 commented Sep 4, 2025

TODO - check DM'd code which has config and command toggle

@lokka30
Copy link
Member

lokka30 commented Sep 9, 2025

Thanks @Samuelteal33 - apologies for delay in reviewing this, have been very busy lately!

For some reason the file diffs that git wants to merge in are really whack - unclear what's caused this, maybe a difference in how our IDEs are formatting code if I were to guess.

Basically this will require manual fixes on my end to get the diff back in order otherwise it will be a messy commit

@Samuelteal33
Copy link
Author

Sorry about that @lokka30. Yeah, I am not overly familiar with github, so may be some differences that I am not familiar with.

@lokka30
Copy link
Member

lokka30 commented Sep 16, 2025

No probs at all, I've myself caused mayhem with git in the past (and present!..). I've found it is indeed some whitespace or line ending related issue which I'll likely be able to fix by re-formatting master and this PR respectively via Prettier or something, then the diff should clean up and can move forward from there.

Thanks for doing some code cleanup too, always pays to have another set of eyes over the work 🙂

Life is still so busy, unfortunately - though at least you've got it working on your end - now it's just a matter of public access to the changes and attribution. I'll update once I can next work on this since I'm being the hold up.

Edit 29/09/2025: once able, I'll likely approach as so:

  • interactive rebase
  • use --whitespace=fix
  • initial review
  • include changes outside PR for configuration
  • final review + test
  • squash & merge
  • release

@lokka30 lokka30 added state: in review Maintainers are currently reviewing this and removed state: in progress Work is currently in progress to resolve this labels Sep 16, 2025
@lokka30
Copy link
Member

lokka30 commented Dec 12, 2025

Hi @Samuelteal33, just wanted to update (a long while later) that unfortunately I don't have the capacity to continue working on this project, or at least for now. I'll keep this open in case this changes or if a new maintainer is able to work on this.

@lokka30 lokka30 removed their request for review December 12, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort: medium This will require a normal amount of work relative to other issues platform: bukkit Affects the Bukkit platform priority: medium This should be resolved in the near future state: in review Maintainers are currently reviewing this type: feature Requests a new or improved feature

Projects

Status: In Queue

Development

Successfully merging this pull request may close these issues.

Add 'payment received' message for targets in /pay

2 participants