-
-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add VS Code extension recommendations #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't know offhand what Alternatively, does it make more sense to unignore this specific file in .gitignore? |
|
|
|
Hm. Unless github desktop is doing unusual checkout and stage commands, I don't think that works. |
How do you mean? Do the file changes not show up when checking out this branch? |
|
Didn't test that much yet, but I believe repo file changes overwrite existing content and local changes to files are tracked. That's been my experience in the past: .gitignore doesn't matter once a file is tracked. You can work around it on an individual basis (skip-worktree, or something?) but I never found a way to do it from the repo side. |
|
Ah! That's... interesting, and unexpected. Let me play with it. |
|
I could definitely be wrong! But I'm trying to imagine how it would work if I am wrong. Presumably what you want is "a clone to an empty folder includes the file but a clone to a— ...okay, I'm not sure I actually know how to finish that sentence :D |
|
What I was going for was a committed version of doing |
|
Hm, closing this was silly. I made a bad assumption about the details (#2052 deserves to stay closed) but this file in particular shouldn't need to be touched by individual developers unless they're planning to propose new recommended extensions anyway. |
|
No changes to gitignore needed to continue to ignore other files in the |
marcustyphoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extension page for git graph crashes in my vs code, so that's fun, but I don't think that's related to the PR :D
Description
Another little thing in my "hey let's make the repository more friendly to new contributors" crusade.
These are all the VS Code extensions I use when developing addons. Yes, all six of them.
I think being able to trivially configure your workspace to match that of the author-maintainer is useful, no?
This is committed via
git add --forcerather than modifying our gitignore file, so other changes to files in the.vscode/directory remain untracked by default. This allows individuals to customise their workspace for this repository without theirsettings.jsongetting picked up by git and unintentionally pushed as part of a PR.Testing steps
@recommended(I assume that a fresh VS Code install would, upon starting up with this file committed, prompt to install these if they're not already installed; I can make no assumptions about your install, so I don't know if you'll be prompted!)