Add no_remove flag #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues: - BSD head/tail don't support the +/- specifications. Use "-q -q" to unzip instead to remove headers and footers. - "python2" isn't guaranteed to exist. Use the current interpreter.
This is necessary under --python_path=python3 and other relative paths, which is in turn necessary to support builds across multiple environments with python3 installed in different locations.
Fixed usage of `expr` that is not supported on Mac OS. Fixed case when $(which python3) returned false.
- depset is not iterable - tools should be separate from other inputs
Cleanup for Bazel future changes
Python interpreter can now be overridden
This updates to a recent version of Skydoc so that doc generation works on modern versions of Bazel.
Two tiny fixes to rename `default_python_version` for a `py_binary` target and to change the syntax of a return. This does not rename the `default_python_version` attribute on the `parfile` rule. That attribute is currently marked mandatory, though it doesn't appear to be used. If we want to keep it, and if we want a gentle migration period, we'd need to introduce a new `python_version` attribute for `parfile`, make them both non-mandatory, and validate them at anaylsis time, similarly to how Bazel handled the rename of this attribute for `py_binary`/`py_test`.
* Make remove_if_present atomic * Fix typo * Pass import roots directly from Bazel to compiler via args * Replace default python toolchain wrappers with /usr/bin/env python[23] * Replace Skylark with Starlark * Update tests for CLI * Update CLI args for naming consistency * Fail when python interpreter is a relative path and improve comments
This adds a hook file for run_tests.sh to write toolchain info to before each bazel invocation. This replaces the legacy way of passing an interpreter in via --python_path. It also replaces a config_setting that was used to control whether PY2 or PY3 was used, with a simple constant symbol consumed at loading time. This is needed in order to make the target aware at analysis time of which version it is building for. Fixes google#98, fixes google#102.
…#106) Fixes google#105 by 1) enabling toolchains in the workspace .bazelrc, and 2) making the test harness filter out runfiles added by the autodetecting toolchain. Previously, the tests worked when run from run_tests.sh but failed in `bazel test //...`. This caused travis to pass but buildkite to fail. Also fixed a typo that caused run_test.sh to fail on some versions of bash.
This will be useful to keep up-to-date for documentation purposes, and so we know when a release cut breaks compatibility with Bazel and therefore needs to be a major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google#84