Skip to content

Comments

Fix loading state and error display issues#2

Merged
petre-c merged 6 commits intomainfrom
feat/georgian-dark-mode-chart
Jul 13, 2025
Merged

Fix loading state and error display issues#2
petre-c merged 6 commits intomainfrom
feat/georgian-dark-mode-chart

Conversation

@petre-c
Copy link
Contributor

@petre-c petre-c commented Jul 12, 2025

Summary

  • Fixed initial loading spinner showing on page load
  • Fixed chart not loading on initial render
  • Fixed Blazor error UI incorrectly displaying

Changes

  1. Removed initial loading state: Added initialLoad flag to prevent showing spinner on first load
  2. Fixed chart loading: Implemented proper lifecycle management with chartNeedsUpdate flag to ensure chart loads after DOM is ready
  3. Hidden error UI: Added inline styles to completely hide Blazor's error UI that was showing incorrectly

Test plan

  • Verify no loading spinner appears on initial page load
  • Confirm chart loads immediately when page opens
  • Check that no error messages display at bottom of page
  • Test currency switching updates chart correctly
  • Verify exchange rates load and display properly

Petre Chitashvili and others added 6 commits July 9, 2025 17:44
- Translate entire UI to Georgian language
- Implement full dark mode theme with custom color scheme
- Limit currency selection to USD, EUR, and GBP only
- Replace exchange rates grid with 14-day historical chart
- Add Chart.js integration for visualizing rate trends
- Update navigation and loading states to Georgian
- Optimize for better mobile responsiveness
- Fix JSON deserialization issues with API response

The app now provides a modern, dark-themed Georgian interface with
visual rate history for better user experience.

*Collaboration by Claude*
- Add manual preview deployment workflow for any branch
- Add build and test workflow for all PRs
- Update README with detailed deployment instructions
- Include development setup and contribution guidelines
- Remove initial loading spinner to prevent flash on page load
- Add initialLoad flag to track first load vs subsequent loads
- Fix chart not loading on initial page render by managing chartNeedsUpdate flag
- Hide Blazor error UI that was displaying incorrectly
- Improve component lifecycle management for chart updates

*Collaboration by Claude*

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@petre-c petre-c merged commit d87da30 into main Jul 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant