Improve TCP connect timeout handling in ModbusTcpClient #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure exceptions from ConnectAsync are observed to prevent unhandled task exceptions. Close TcpClient on timeout to cancel pending connections and enhance robustness against connection failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the connection logic in the
ModbusTcpClientinitialization to handle connection timeouts more robustly. The main change ensures that exceptions from failed connection attempts are properly observed, preventing potential process crashes or excessive logging.Connection handling improvements:
ModbusTcpClient.csto observe exceptions from failedConnectAsynctasks by attaching a continuation that accessestask.Exception, ensuring unhandled exceptions do not crash the process or flood logs. Also, theTcpClientis explicitly closed on timeout to cancel the connection attempt.