timestmap fix #431
timestmap fix #431
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #427 (“Chat Time Stamps Desynced”) by changing chat RPCs to include an explicit UTC timestamp from the sender, instead of deriving the timestamp from Photon’s server/network time values (which can drift/reset across restarts).
Changes:
- Add a
senderTimestamp(longticks) parameter toChatRPCandPrivateChatRPC. - Send
DateTime.UtcNow.Tickswith chat/private chat RPC calls. - Use the passed tick timestamp to construct the displayed timestamp in chat/private chat handlers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Assets/Scripts/GameManagers/RPCManager.cs | Extends chat-related PunRPC method signatures to forward an explicit sender timestamp. |
| Assets/Scripts/GameManagers/ChatManager.cs | Sends UTC ticks with outgoing chat RPCs and uses them for incoming message timestamps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
what in the world |
Don't use that, it wastes money used for bandwidth |
|
it did it automatically, didn't realized it was enabled |
you have to hit request review on copilot - we have no way to turn it off :^( |
2 participants
Resolves: #427