Skip to content

Conversation

@blackshoot01
Copy link

No description provided.

@blackshoot01
Copy link
Author

As you requested, I have removed the VideoPlayer cache from CustomLogicTransformBuiltin and add the GetUnityComponent method to CustomLogicMapObjectBuiltin. I also use reflection to automatically find and return BuiltinComponentInstance of the associated Unity component as long as the unity component has been registered beforehand

Copy link
Collaborator

@AutumnThyme AutumnThyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I will look to add a way to support setting video URLs soon.
I need to add a service for pre-registering URLs so that users can be prompted in advanced before running CL that accesses external websites.

There is some research on the security side I need to confirm before this will be ready (avoiding redirects, direct downloads, or other weird http operations that links can support)

@AutumnThyme
Copy link
Collaborator

@blackshoot01 Can you pull latest main and rebase/merge it into your changes? I can't resolve the conflict on my side since this is on a fork. Other than that, this is all good.

@blackshoot01
Copy link
Author

@blackshoot01 Can you pull latest main and rebase/merge it into your changes? I can't resolve the conflict on my side since this is on a fork. Other than that, this is all good.

Ok, I have no idea about the information in this file so I will just keep change from the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants