-
Notifications
You must be signed in to change notification settings - Fork 60
[CL] Added VideoPlayer builtin component #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Assets/Scripts/CustomLogic/Builtin/Entities/CustomLogicTransformBuiltin.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/CustomLogic/Builtin/Entities/CustomLogicTransformBuiltin.cs
Outdated
Show resolved
Hide resolved
|
As you requested, I have removed the VideoPlayer cache from CustomLogicTransformBuiltin and add the GetUnityComponent method to CustomLogicMapObjectBuiltin. I also use reflection to automatically find and return BuiltinComponentInstance of the associated Unity component as long as the unity component has been registered beforehand |
AutumnThyme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I will look to add a way to support setting video URLs soon.
I need to add a service for pre-registering URLs so that users can be prompted in advanced before running CL that accesses external websites.
There is some research on the security side I need to confirm before this will be ready (avoiding redirects, direct downloads, or other weird http operations that links can support)
|
@blackshoot01 Can you pull latest main and rebase/merge it into your changes? I can't resolve the conflict on my side since this is on a fork. Other than that, this is all good. |
Ok, I have no idea about the information in this file so I will just keep change from the main branch |
No description provided.