Skip to content

Conversation

@hongyaohongyao
Copy link
Contributor

Create humans from custom characters through custom logic; expose more human (AI-only) properties and atomic-level actions; flexibly control human actions through action programming.

@AutumnThyme AutumnThyme self-requested a review August 16, 2025 20:53
Copy link
Collaborator

@AutumnThyme AutumnThyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this requires a comment now, I thought I've hit this button like 5 times now.
Look at the comments and resolve the issues.
Main takeaways here is that if AI humans are not in use, there shouldn't be any changes to the colliders, triggers, or logic. We don't want performance drops for features that are not in use.

@AutumnThyme
Copy link
Collaborator

Also again I'm going to be very strict on this because I've already been burnt by people haphazardly changing the way the character works. Ultimately I just want to isolate what we have right now and keep a legacy character option. We can change other stuff but without this legacy option we're just going to for 1. limit what we can do and 2. constantly burn dev time to ensure compatibility.

Copy link
Collaborator

@AutumnThyme AutumnThyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me some time to do a test build and performance testing on this stuff.

If there are issues, this probably won't be in the immediate next update (though we will probably do a patch shortly after like after every big update so it would fit in there if the issues are resolved in time)

Everything else (code-wise) looks good.

@AutumnThyme
Copy link
Collaborator

Hooks are phasing through titans and performance feels a bit worse.
The first issue needs to be resolved and then I will do performance testing on it.
This is why I stress not touching the human class, even though everything looks normal, its extremely easy to break stuff.

@hongyaohongyao
Copy link
Contributor Author

hongyaohongyao commented Aug 27, 2025

Hooks are phasing through titans and performance feels a bit worse. The first issue needs to be resolved and then I will do performance testing on it. This is why I stress not touching the human class, even though everything looks normal, its extremely easy to break stuff.

it seems the activation of titan’s colliders depend on HumanDection. The player human actually always has HumanDection, but I removed it on your advice (the awkward thing is, I thought it useless too..) and forgot to retest when only the player human is present. Anyway, I copied the original HumanDection from the main branch and added a separate AIHumanDetection for the AI. The issue appears to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants