Moved air dash brake code to FixedUpdate #299
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change 1
The slowdown/braking effect that slows you after using air dash was FPS dependent due to being executed in
Update(). I moved the code toFixedUpdate()to fix that.Change 2
I interpreted that the purpose of the
Cache.Rigidbody.velocity.magnitude > _originalDashSpeedcheck was to prevent the slowdown from removing more speed that was added by the air dash. However, this check does not take into account the direction of the dash force, so I added a new field_originalDashDirectionto track the direction of the dash, and updated the use of_originalDashSpeedto track the speed only in that direction. Lastly, I added a branch to the code that updates the velocity to correctly avoid removing more speed in the direction of the dash than was added by it.Misc change
I also did a small change to the
DashandDashVerticalmethods so that they update_dashTimeLeftafter settingState = HumanState.AirDodge. This is to prevent any potential bug in the case thatStateis ever updated toAirDodgewhile it is already set toAirDodge, since theStatesetter clears_dashTimeLeftin that case.Note
This code should still be optimized and refactored before committing to main, but please test and make sure the functionality is working properly.