Skip to content

Split domain management#17

Open
Anunayj wants to merge 4 commits intomasterfrom
split-domain-management
Open

Split domain management#17
Anunayj wants to merge 4 commits intomasterfrom
split-domain-management

Conversation

@Anunayj
Copy link
Owner

@Anunayj Anunayj commented Oct 25, 2021

No description provided.

MTX clone() would not carry over coinview, in order to get around this the CoinSelector
would remove all inputs and add them back which made working with partially signed
transactions a pain, this should fix that issue.
Previous version of interactive-name-swap used a ugly hack to get around limitations
on wallet funding, since wallet.fund() no longer wipes previous inputs, the previous
implementation is not longer the recommended way.
@Anunayj Anunayj force-pushed the split-domain-management branch from 1e637c2 to f51c581 Compare October 25, 2021 23:48
@coveralls
Copy link

coveralls commented Oct 25, 2021

Pull Request Test Coverage Report for Build 1391888685

  • 23 of 24 (95.83%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 62.232%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/primitives/mtx.js 11 12 91.67%
Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 69.11%
Totals Coverage Status
Change from base Build 1298129848: 0.01%
Covered Lines: 21176
Relevant Lines: 31806

💛 - Coveralls

@Anunayj Anunayj force-pushed the split-domain-management branch 2 times, most recently from 79bde70 to eecf36f Compare October 27, 2021 20:33
Example script to have seperate keys for UPDATEing and TRANSFERing domains + anyone can renew

Co-authored-by: Matthew Zipkin <pinheadmz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants