Remove Windows support, Linux/macOS only (v3.0.0)#49
Merged
Conversation
BREAKING CHANGES: - mb_os_call signature: (linux_cmd, mac_cmd, use_shell) - removed windows param - mb_os_assign signature: (linux_cmd, mac_cmd) - removed windows param Removed: - mb_powershell, mb_powershell_cmdlets, mb_powershell_expression functions - mb_ask_user_windows function - Windows-specific branches in mb_printf_statement, mb_os_call, mb_os_assign - Windows format specifiers from mb_printf_*_format_specifier variables - Windows self-update code (PowerShell) from Makefile.tpl.mk Changed: - mb_os_is_windows now only detects Windows to show helpful WSL error - WSL detection checks uname first (WSL has OS=Windows_NT but uname=Linux) - mb_downloader uses curl for both Linux/macOS (more universal) Added: - os_detection_test.mk with 8 tests for OS detection - printf_test.mk with 10 tests for printf functions - Additional util tests for timestamp, random, unzip, downloader Tests: 134 tests, 288 assertions - all passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_os_callandmb_os_assignsignatures changed (removed Windows parameter)unamebefore erroring onOS=Windows_NTChanges
Removed:
mb_powershell,mb_powershell_cmdlets,mb_powershell_expressionfunctionsmb_ask_user_windowsfunctionChanged:
mb_os_is_windowsnow only detects Windows to show helpful WSL errormb_downloaderuses curl for both Linux/macOS (more universal)Added:
os_detection_test.mk- 8 tests for OS detectionprintf_test.mk- 10 tests for printf functionsTest plan
🤖 Generated with Claude Code