Fix PHP staged targets in docker mode (v2.2.9)#45
Merged
Conversation
- Add mb_staged_strip_prefix config to align git paths with container paths - Add php_run_on_staged helper that passes files inside docker invoke - Update phpcs/phpstan/psalm staged targets to use new helper - Add config options to templates/config.tpl.mk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php/phpcs/staged,php/phpstan/staged,php/psalm/stagedwere broken in docker modemb_run_on_stagedappended files outside docker shell quotesphp_run_on_stagedhelper passes files inside the invoke callmb_staged_strip_prefixconfig for aligning git paths with container pathsChanges
core/util/git.mk: Addmb_staged_strip_prefixconfigmodules/php/php/php.mk: Addphp_run_on_stagedhelpermodules/php/phpcs/phpcs.mk: Use new helpermodules/php/phpstan/phpstan.mk: Use new helpermodules/php/psalm/psalm.mk: Use new helpertemplates/config.tpl.mk: Add config options with examplesTest plan
php/phpcs/stagedin docker mode with staged PHP filesmb_staged_strip_prefixstrips paths correctly