Fix duplicate targets in listing after bind-hub restructure (v2.2.3)#38
Merged
Fix duplicate targets in listing after bind-hub restructure (v2.2.3)#38
Conversation
- Add %/project.mk and %/config.mk to filter-out patterns in mb_targets_list_get_files - These patterns were missing after v2.1.1 renamed mb_project.mk to project.mk and mb_config.mk to config.mk - Without the filter, project.mk was included in both $0_files_project and $0_other_files_in_bind_hub_folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeoutput after bind-hub restructure (v2.1.1)project.mkandconfig.mkweren't filtered out of$0_other_files_in_bind_hub_folder%/project.mkand%/config.mkto filter-out patterns inmb_targets_list_get_filesTest plan
project/start/with_tests_supportstill appears twice due to duplicate##comments in that project'sproject.mk(not a MakeBind issue)