Refactor terraform module to use tf_no_var_file_cmds list#37
Merged
Conversation
- Add tf_no_var_file_cmds config variable (default: init validate output state) - tf_run now checks if command is in list instead of using skip_vars parameter - Use mb_is_true instead of $(filter $(mb_true),...) for boolean checks - Remove skip_vars parameter from tf_run (cleaner API) - Update tests to verify commands in list skip -var-file
AntonioCS
deleted the
improvement/terraform-use-no-var-file-cmds-list
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_varsparameter with configurabletf_no_var_file_cmdslisttf_no_var_file_cmdsconfig variable (default:init validate output state)tf_runnow automatically checks if command is in the listmb_is_trueinstead of$(filter $(mb_true),...)for boolean checksTest plan
test_modules_terraform_run_no_var_file_cmdsverifies:-var-file-var-file