This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Arbitrary container and image names allow for non-destructive testing#229
Draft
ScottBailey wants to merge 3 commits intomainfrom
Draft
Arbitrary container and image names allow for non-destructive testing#229ScottBailey wants to merge 3 commits intomainfrom
ScottBailey wants to merge 3 commits intomainfrom
Conversation
Contributor
|
Some tests are failing, so I will hold on with the review |
ScottBailey
force-pushed
the
sbailey/arbitrary_container_and_image_names
branch
from
bd95c42 to
5b4734f
Compare
ScottBailey
changed the title
…mes on the command line. This allows for the user to have more than one container as well as having non-destructive regression tests. `.pylintrc`: made column number larger. `src/dunes/__main__.py`: Container creatin uses the new CLI arguments. `src/dunes/args.py`: Add the new CLI options, fix forwarded args functions to work with container name. `src/dunes/docker.py`: `__init__()` becomes more sophisticated and `upgrade()` becomes more self contained. `src/dunes/dunes.py`: `__init__()` now takes container and image names. `tests/*`: Tests are updated to replace `destructive` with `safe` in all cases except the a100 test which must remain destructive. Changed language in README.
ScottBailey
force-pushed
the
sbailey/arbitrary_container_and_image_names
branch
from
da80789 to
e7919c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates dunes to optionally take a container and image names on the command line. This allows for the user to have more than one container as well as having non-destructive regression tests.
.pylintrc: made column number larger.src/dunes/__main__.py: Container creatin uses the new CLI arguments.src/dunes/args.py: Add the new CLI options, fix forwarded args functions to work with container name.src/dunes/docker.py:__init__()becomes more sophisticated andupgrade()becomes more self contained.src/dunes/dunes.py:__init__()now takes container and image names.tests/*: Tests are updated to replacedestructivewithsafein all cases except the a100 test which must remain destructive. Changed language in README.Closes #213