Skip to content

Conversation

@jim3ma
Copy link

@jim3ma jim3ma commented Jun 15, 2016

  • Add --ami_tags option

--ami_tags Role:Linux,Build:C

  • Change AMI_ID to --ami_id

--ami_id ami-1e13de1

  • Update project badges

@pas256
Copy link
Member

pas256 commented Jun 22, 2016

Hi @jim3mar. Thanks for the PR.

The addition of --ami_tags is nice (would prefer it to be --ami-tags) but we cannot change the positional argument to require --ami_id.

Would you mind modifying this PR to fix those 2 things so I can merge it?

@jim3ma
Copy link
Author

jim3ma commented Jun 23, 2016

Hi @pas256

I have modified the ami-id for backward compatibility.

When setting the special ami-id, the tags should not be setting.
When the ami-id is "-", the tags can work OK.

distami --region us-east-1 --to us-west-1 ami-abcd1234
distami --region us-east-1 --to us-west-1 --ami-tags Name:Linux,Version:3 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants