Skip to content

Conversation

@pydanny
Copy link
Contributor

@pydanny pydanny commented May 5, 2025

While this looks like a HUGE change, in reality it is minimal. What it does:

  1. Replaces use of the tempfile.TemporaryDirectory() context processor with the tmp_path pytest fixture, which provides a Path object instead of a string
  2. Using this fixture flattens the code, making it easier to read and maintain

Note

This will be pulled out of draft once the other tests are converted to use tmp_path

@pydanny pydanny self-assigned this May 5, 2025
@pydanny pydanny added the enhancement New feature or request label May 5, 2025
@jph00
Copy link
Contributor

jph00 commented Jun 7, 2025

@algal looks like there's some minor changes still needed based on the description before this can be merged.

@algal
Copy link
Contributor

algal commented Jun 9, 2025

@jph00 Yeah. I think this is still marked draft becaase it's not complete. It's not ready for review or merge.

@jph00
Copy link
Contributor

jph00 commented Aug 30, 2025

@algal would be nice to get this finished and merged - wdyt?

@algal algal self-assigned this Sep 2, 2025
@algal
Copy link
Contributor

algal commented Sep 2, 2025

On it!

@algal
Copy link
Contributor

algal commented Sep 9, 2025

Working this on a new branch:

https://github.com/AnswerDotAI/fastmigrate/tree/flatten-tests2

@algal
Copy link
Contributor

algal commented Sep 10, 2025

@pydanny Hey Danny! I'm not sure if you have time for this at the moment, but if you are curious to give it a look, I continued this work and replaced all uses of tempfile.TemporaryDirectory() in order to reduce nesting. The main branch had moved ahead so much that I put the work in a fresh branch, https://github.com/AnswerDotAI/fastmigrate/tree/flatten-tests2 .

I assume you're probably busy with other things, but please let me know if you care to give it a review. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants