Open
Conversation
oleg-preply
requested changes
Oct 10, 2018
Collaborator
oleg-preply
left a comment
oleg-preply
left a comment
There was a problem hiding this comment.
great progress!!! 😄
| setLanguages: languages => dispatch (setLanguages (languages)), | ||
| setScreens: screens => dispatch (setScreens (screens)), | ||
| resetState: () => dispatch(resetState()), | ||
| abstractSetter: (data) => dispatch(abstractSetter(data)), |
Collaborator
There was a problem hiding this comment.
could be just const mapDispatchToProps = { resetState, abstractSetter }
|
|
||
| const App = connect (mapStateToProps, mapDispatchToProps) (ConnectedApp); | ||
| const App = connect(mapStateToProps, mapDispatchToProps) (ConnectedApp); | ||
| export default App; |
Collaborator
There was a problem hiding this comment.
export default connect(mapStateToProps, mapDispatchToProps) (ConnectedApp); saves you one line 
|
|
||
| export const resetState = createAction('RESET_STATE'); // TODO: doesn't work correctly (languages and screens multiselect is not re-rendered) | ||
|
|
||
| export const abstractSetter = createAction('SET'); |
Collaborator
There was a problem hiding this comment.
abstractions in Redux are dangerous things since might become unmaintainable at some point.
Would suggest firstly split it back to separate actions/reducers and after that use combineActions (or other way of doing that) of redux-actions
| const reducer = handleActions( | ||
| { | ||
| [resetState]: () => ({ ...initialState}), | ||
| [abstractSetter]: (state, {payload: {value, type}}) => { let newState = {...state}; newState[type] = value; return newState; }, |
Collaborator
There was a problem hiding this comment.
could be shorter:
[abstractSetter]: (state, {payload: {value, type}}) => ({...state, [type]: value }),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.