Simplify CI #54
Closed
Simplify CI #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the CI workflow but introduces additional complexity and duplication. The changes add UV_FROZEN environment variable management and a duplicate package installation step, which appears contrary to the "simplify" objective stated in the PR title.
Key Changes:
- Added
UV_FROZEN: trueenvironment variable at the job level - Modified the first installation step to unset
UV_FROZENbefore runninguv sync --locked - Added a second, duplicate installation step named "Install Python packages2"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/pull_request.yaml
Outdated
Comment on lines
43
to
47
| - name: Install Python packages2 | ||
| run: | | ||
| uv sync --locked | ||
| shell: bash | ||
|
|
There was a problem hiding this comment.
The step name "Install Python packages2" appears to be a placeholder or temporary name. This should be renamed to something more descriptive that explains why this step exists separately from the first installation step, or if this is duplicated, one of the steps should be removed.
Suggested change
| - name: Install Python packages2 | |
| run: | | |
| uv sync --locked | |
| shell: bash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.