Remove poethepoet and add a Makefile #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request replaces poethepoet as a task runner with a traditional Makefile. The change simplifies the project's tooling by removing a Python-specific task runner in favor of the widely-used Make build automation tool.
- Removes the poethepoet dependency and its configuration from pyproject.toml
- Adds a new Makefile with a
check-codetarget that runs ruff and ty checks - Updates the CI workflow to use the new Make-based command
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uv.lock | Removes poethepoet (0.38.0) and its dependency pastel (0.2.1) from the lock file |
| pyproject.toml | Removes poethepoet from dev dependencies and removes the [tool.poe.tasks] configuration section |
| Makefile | Adds new file with check-code target executing ruff check, ruff format --diff, and ty check via uv run |
| .github/workflows/pull_request.yaml | Updates CI workflow to use make check-code instead of uv run --frozen -- poe check-code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.