Changed Shape form for Thumb and Track from Circle to Rounded Rectangle.#3
Open
timskap wants to merge 1 commit intoAndreiMisiukevich:mainfrom
Open
Changed Shape form for Thumb and Track from Circle to Rounded Rectangle.#3timskap wants to merge 1 commit intoAndreiMisiukevich:mainfrom
timskap wants to merge 1 commit intoAndreiMisiukevich:mainfrom
Conversation
Author
|
Comment on lines
+43
to
+59
| public double ThumbCornerRadius | ||
| { | ||
| get => (double)GetValue(ThumbCornerRadiusProperty); | ||
| set => SetValue(ThumbCornerRadiusProperty, value); | ||
| } | ||
|
|
||
| public double LowerThumbCornerRadius | ||
| { | ||
| get => (double)GetValue(LowerThumbCornerRadiusProperty); | ||
| set => SetValue(LowerThumbCornerRadiusProperty, value); | ||
| } | ||
|
|
||
| public double UpperThumbCornerRadius | ||
| { | ||
| get => (double)GetValue(UpperThumbCornerRadiusProperty); | ||
| set => SetValue(UpperThumbCornerRadiusProperty, value); | ||
| } |
Owner
There was a problem hiding this comment.
Please make sure all instance properties are near other instance properties. I suggest to append them to the bottom
Comment on lines
+34
to
+41
| public static BindableProperty ThumbCornerRadiusProperty = | ||
| BindableProperty.Create(nameof(ThumbCornerRadius), typeof(double), typeof(RangeSlider), 10.0, propertyChanged: OnLayoutPropertyChanged); | ||
|
|
||
| public static BindableProperty LowerThumbCornerRadiusProperty = | ||
| BindableProperty.Create(nameof(LowerThumbCornerRadius), typeof(double), typeof(RangeSlider), -1.0, propertyChanged: OnLayoutPropertyChanged); | ||
|
|
||
| public static BindableProperty UpperThumbCornerRadiusProperty = | ||
| BindableProperty.Create(nameof(UpperThumbCornerRadius), typeof(double), typeof(RangeSlider), -1.0, propertyChanged: OnLayoutPropertyChanged); |
Owner
There was a problem hiding this comment.
- please fix the formatting (indention).
- put props to the appropriate place
| set => SetValue(UpperThumbCornerRadiusProperty, value); | ||
| } | ||
|
|
||
| // Track Corner Radius |
Owner
There was a problem hiding this comment.
please drop these redundant comments
| } | ||
|
|
||
| static Border CreateBorderElement<TBorder>(bool hasShadow = false) where TBorder : Border, new() | ||
| static Border CreateBorderElement<TBorder>(bool hasShadow = false) where TBorder : Border, new() |
Owner
There was a problem hiding this comment.
indetion
make sure it's correct across the entire file
| // ShadowEffect.SetOpacity(frame, .25); | ||
| // ShadowEffect.SetRadius(frame, 3); | ||
| // ShadowEffect.SetOffsetY(frame, 2); | ||
| CornerRadius = new CornerRadius(10) // Adjust for rounded corners |
Owner
There was a problem hiding this comment.
why is it hardcoded 10 here?
Comment on lines
-549
to
-552
| Track.StrokeShape = CreateRoundRectangleShape(trackRadius); | ||
| TrackHighlight.StrokeShape = CreateRoundRectangleShape(trackRadius); | ||
| LowerThumb.StrokeShape = CreateRoundRectangleShape((float)GetDoubleOrDefault(GetDoubleOrDefault(LowerThumbRadius, ThumbRadius), lowerThumbSize / 2)); | ||
| UpperThumb.StrokeShape = CreateRoundRectangleShape((float)GetDoubleOrDefault(GetDoubleOrDefault(UpperThumbRadius, ThumbRadius), upperThumbSize / 2)); |
Owner
There was a problem hiding this comment.
why did you get rid of CreateRoundRectangleShape usage? now this method is not used
AndreiMisiukevich
requested changes
Feb 6, 2025
Owner
AndreiMisiukevich
left a comment
AndreiMisiukevich
left a comment
There was a problem hiding this comment.
Hello! Thank you very much for your contribution. I appreciate that.
Unfortunately this PR is not ready to be merged.
Need to fix next things:
- Correct formatting
- Correct props place of definition (bindable and instance)
- Do not make unrelated changes in code base.
- Need to adjust documentation in Readme.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it has a