Removed code that prevent mkxp from running when sound engine can't initialize#249
Open
mbrethes wants to merge 1 commit intoAncurio:masterfrom
Open
Removed code that prevent mkxp from running when sound engine can't initialize#249mbrethes wants to merge 1 commit intoAncurio:masterfrom
mbrethes wants to merge 1 commit intoAncurio:masterfrom
Conversation
card detected or configured on the system. Maybe we should throw an alert message, but it's perfectly OK to run games without sound most of the time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ancurio,
First of all thanks for this amazing work you did!
When there is no sound card detected or configured on the system, it should still be OK to run games (I have had to do that to run MXKP on a Raspberry PI emulated with QEMU, as emulation does not handle the sound card). So I removed the blocking tests, and the games still seem to run fine.
Maybe we should throw a non-critical alert message when the engine fails to initialize its sound system? In that case, do not hesitate to add code for that.
Cheers!
Mathieu