Use lambda-git #43
Open
Use lambda-git #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uploading expanded git-2.4.3.tar causes failure for exceeding upload size limitations.
ikedam
commented
Sep 17, 2018
| if (gitExpand && fs.existsSync(GitPath)) { | ||
| // Use the existing one as it takes much time to expand git everytime. | ||
| return execGitCmdImpl(cmd, cwd, env); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
process.js often fails for timeouts ( > 40s) without this.
Owner
|
LGTM. |
Contributor
Author
|
I agree adding tests improves our development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though it looks expected to have opt/git-2.4.3.tar expanded when deploying, it results following error:
This request uses lambda-git instead.