feat: update to @inquirer/prompts, use search for region select#908
Draft
nathanjsharpe wants to merge 4 commits intoAnWeber:mainfrom
Draft
feat: update to @inquirer/prompts, use search for region select#908nathanjsharpe wants to merge 4 commits intoAnWeber:mainfrom
nathanjsharpe wants to merge 4 commits intoAnWeber:mainfrom
Conversation
nathanjsharpe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from
inquirerto@inquirer/promptsand uses search for region select rather than a raw list.If you have a lot of regions, the region select can be tedious. I know you can specify files to reduce the regions available, but it's nice to not have to, especially when running interactively and combining requests from different files.
I used
fuzzysortfor the search because it's tiny, fast, has no dependencies, and provides all the functionality that we would reasonably need.I gave up on figuring out the magic incantation to make dynamic imports work with the new packages in tests. Instead, I just injected them so I could pass mocks for tests.