Fix proper system bar handling #85
Merged
+35
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gurnoorpannu
commented
Oct 15, 2025
gurnoorpannu
commented
- Add MaterialToolbar with AppBarLayout to MainActivity layout
- Update themes to use NoActionBar parent for custom toolbar
- Enable fitsSystemWindows for proper system bar handling
- Adjust fragment container layout to prevent content overlap
- Add MaterialToolbar with AppBarLayout to MainActivity layout - Update themes to use NoActionBar parent for custom toolbar - Enable fitsSystemWindows for proper system bar handling - Adjust fragment container layout to prevent content overlap
Contributor
Author
|
@AmrDeveloper can you review this? |
Owner
|
Sure @gurnoorpannu, I will review it soon |
AmrDeveloper
approved these changes
Oct 17, 2025
Owner
AmrDeveloper
left a comment
AmrDeveloper
left a comment
There was a problem hiding this comment.
LGTM, Thanks for working on this.
can you please share a screenshot after this on the same device?
Contributor
Author
|
@AmrDeveloper here you go! |
Owner
|
Great, thank you for fixing it @gurnoorpannu |
This was referenced Oct 19, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.