Skip to content

WEB-232 Update Sitecore Back end solution to 9.3#1

Open
vincentlui-alinta wants to merge 5 commits intomasterfrom
feature/sitecore-9.3
Open

WEB-232 Update Sitecore Back end solution to 9.3#1
vincentlui-alinta wants to merge 5 commits intomasterfrom
feature/sitecore-9.3

Conversation

@vincentlui-alinta
Copy link

Fixing all the breaking changes for the Redirect module

Copy link

@daniel-simpson-alinta daniel-simpson-alinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm amazed that there isn't something similar in the upstream repo.

Edit: I just looked at the upstream and its targeting Sitecore 8.2? 😱

@daniel-simpson-alinta
Copy link

Looks like our repo was forked from a fork... Is it worth submitting these changes as a PR back to the original repo? https://github.com/iamandycohen/UrlRewrite

@vincentlui-alinta
Copy link
Author

Looks like our repo was forked from a fork... Is it worth submitting these changes as a PR back to the original repo? https://github.com/iamandycohen/UrlRewrite

I am a bit hesitant to do a PR back into the original repo as it has not been maintained for so long. Also don't forget that ideally this module should be removed from Alinta's solution soon rather than later. I would prefer to give this PR more TLC if it's going back to the original repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants