Skip to content

[OGUI-1777] Create command for alerting central system on security risks #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OmegaCreations wants to merge 159 commits into
base: dev
Choose a base branch
from
Open

[OGUI-1777] Create command for alerting central system on security risks #3117

OmegaCreations wants to merge 159 commits into from

Conversation

@OmegaCreations
Copy link
Collaborator

@OmegaCreations OmegaCreations commented Oct 10, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

OmegaCreations and others added 30 commits June 8, 2025 20:40
@OmegaCreations
feat: implement basic proto file
464c77f
@OmegaCreations
feat: Duplex stream with specific payload message events.
268a99a
@OmegaCreations
feat: Duplex stream with specific payload message events.
7b7888a
@OmegaCreations
feat: Create typescript interfaces for duplex stream message model
6373548
@OmegaCreations
feat: Add description to typescript interfaces
255e567
@OmegaCreations
feat: implement serialization and deserialization methods
7edca58
@OmegaCreations
feat: add package dependencies and write unit tests for serialization…
0485204 
… utils
@OmegaCreations
fix: fixed oneof variable naming
58666d5
@OmegaCreations
feat: Duplex stream with specific payload message events.
0118271
@OmegaCreations
feat: Create typescript interfaces for duplex stream message model
7c5d552
@OmegaCreations
feat: implement serialization and deserialization methods
4b18459
@OmegaCreations
feat: add package dependencies and write unit tests for serialization…
dba904c 
… utils
@OmegaCreations
feat: Create grpc wrapper with basic connection manager and central s…
273b8e2 
…ystem wrapper
@OmegaCreations
fix: fix grpc addresses to properly connect both client and central s…
6467c55 
…ystem
@OmegaCreations
fix: refactor comments
1a86d49
@OmegaCreations
fix: change central system class name to avoid conflicts with central…
bec195c 
… system
@OmegaCreations
feat: implement Connection class and a map storing all receiving and …
c6a3f01 
…sending connections in ConnectionManager
@OmegaCreations
feat: implement replacing new token for client from central system
fb12e55
@OmegaCreations
feat: implement token revokation by changing connection status
63faee3
@OmegaCreations
fix: remove unnecessary params
456bf84
@OmegaCreations
fix: fix enum naming
93c3a51
@OmegaCreations
fix: fix proto types order based on Bookkeeping standards
ff0faf0
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1702/basic-proto-file' of github.com:A…
d207f78 
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
@OmegaCreations
fix: add copyright banner
fb6c39c
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1702/basic-proto-file' of github.com:A…
8106fe1 
…liceO2Group/WebUi into feature/TKN/OGUI-1703/basic-typescript-interfaces
@OmegaCreations
fix: add copyright banner and change enum naming convention
72042c8
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1703/basic-typescript-interfaces' of g…
d762f9f 
…ithub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1704/data-serialization-utils
@OmegaCreations
fix: fix serialization comments and tests
b70cf9e
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1704/data-serialization-utils' of gith…
aff4c59 
…ub.com:AliceO2Group/WebUi into feature/TKN/OGUI-1705/client-central-basic-stream
@graduta
Merge branch 'dev' into feature/TKN/OGUI-1703/basic-typescript-interf…
9de3ce5 
…aces
OmegaCreations and others added 23 commits November 18, 2025 11:08
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1747/simple-client-p2p-connection' of …
a2d72da 
…github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1754/create-reconnection-scheduler
@OmegaCreations
feat: rebase, write tests for reconnection schaduler and fix it
3bbc627
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1754/create-reconnection-scheduler' of…
0eda640 
… github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1755/secure-connections-with-certificates
@OmegaCreations
fix: rebase and fix rebase and unit tests
3960bb1
@OmegaCreations
fix: binding in peerListener, imports and unit tests
2526344
@OmegaCreations
Merge branch 'dev' into feature/TKN/OGUI-1755/secure-connections-with…
2e5061d 
…-certificates
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1755/secure-connections-with-certifica…
c6851e2 
…tes' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1773/handle-token-validation-for-p2p-c…
a3b8c55 
…onnections' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
@OmegaCreations
Merge branch 'dev' of github.com:AliceO2Group/WebUi into feature/TKN/…
9237316 
…OGUI-1755/secure-connections-with-certificates
@OmegaCreations
fix: rebase
0e256d6
@OmegaCreations
Merge branch 'dev' into feature/TKN/OGUI-1755/secure-connections-with…
0e1f7d4 
…-certificates
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1755/secure-connections-with-certifica…
5149f88 
…tes' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1773/handle-token-validation-for-p2p-connections
@OmegaCreations
fix: fix rebase
95c13cf
@OmegaCreations
fix: rebase and coverage of branches
e6b20e9
@OmegaCreations
fix: package-lock reinstall for pipeline
722fe43
@OmegaCreations
fix: remove unused var
eeb5207
@OmegaCreations
fix: tests
e35533b
@OmegaCreations
fix: temp rename
bc520d2
@OmegaCreations
fix: rename back
d2234c4
@OmegaCreations
fix: unit test
5348b12
@OmegaCreations
fix: imports
b4ac84e
@OmegaCreations
Merge branch 'dev' into feature/TKN/OGUI-1773/handle-token-validation…
305ee9c 
…-for-p2p-connections
@OmegaCreations
Merge branch 'feature/TKN/OGUI-1773/handle-token-validation-for-p2p-c…
c8354b8 
…onnections' of github.com:AliceO2Group/WebUi into feature/TKN/OGUI-1777/command-for-security-alerts
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2025
View reviewed changes
@OmegaCreations
feat: fix tests, extract magic numbers into variables, add more docs,…
b03c5f9 
… improve type safety, add race condition protection and memore leak prevention
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2025
View reviewed changes
...backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts Outdated
});

describe('isRequestAllowed', () => {
const mockCallback = jest.fn();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable mockCallback.

Copilot Autofix

AI 3 days ago

In general, unused variables should be removed to improve readability and avoid confusion. Here, mockCallback is defined but never used inside the describe('isRequestAllowed', ...) block, so the best fix is to delete its declaration line and leave the rest of the tests unchanged.

Concretely, in Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts, within the describe('isRequestAllowed', () => { ... }) block, remove line 335: const mockCallback = jest.fn();. No additional imports, methods, or definitions are required because the variable is not used anywhere.

Suggested changeset 1
Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts b/Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts
--- a/Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts
+++ b/Tokenization/backend/wrapper/src/test/client/ConnectionManager/Interceptors/grpc.auth.interceptor.test.ts
@@ -332,7 +332,6 @@
 });
 
 describe('isRequestAllowed', () => {
-  const mockCallback = jest.fn();
 
   beforeEach(() => {
     jest.restoreAllMocks();
EOF
@@ -332,7 +332,6 @@
});

describe('isRequestAllowed', () => {
const mockCallback = jest.fn();

beforeEach(() => {
jest.restoreAllMocks();
Copilot is powered by AI and may make mistakes. Always verify output.
@OmegaCreations OmegaCreations committed this autofix suggestion 3 days ago.
OmegaCreations and others added 4 commits December 21, 2025 20:13
@OmegaCreations
fix: bump branch coverage
460f0cc
@OmegaCreations @github-advanced-security
Potential fix for code scanning alert no. 340: Unused variable, impor…
9a7ca31 
…t, function or class

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@OmegaCreations
fix: Normalize commands directory casing
e2ba049
@OmegaCreations
fix: imports
34d3d54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@OmegaCreations OmegaCreations

Labels

Tokenization

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OmegaCreations @graduta