Skip to content

[DPG] Specify collisions type in QA efficiency task #14340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fgrosa wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −21
Open

[DPG] Specify collisions type in QA efficiency task #14340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba674a
Specify collisions type in QA efficiency task
fgrosa Dec 23, 2025
9bed191
Fix typename
fgrosa Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions DPG/Tasks/AOTTrack/qaEfficiency.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@
histos.get<TH1>(HIST("eventSelection"))->GetXaxis()->SetBinLabel(2, "Passed Ev. Sel. (no ev. sel)");
} else if (applyEvSel == 1) {
histos.get<TH1>(HIST("eventSelection"))->GetXaxis()->SetBinLabel(2, "Passed Ev. Sel. (sel7)");
} else if (applyEvSel == 2) {

Check failure on line 982 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
histos.get<TH1>(HIST("eventSelection"))->GetXaxis()->SetBinLabel(2, "Passed Ev. Sel. (sel8)");
} else {
LOG(fatal) << "Can't interpret event selection asked " << applyEvSel << " (0: no event selection, 1: sel7, 2: sel8)";
Expand All @@ -1003,7 +1003,7 @@
initMC(axisSel);

// Custom track cuts
if (globalTrackSelection.value == 6) {

Check failure on line 1006 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
customTrackCuts = getGlobalTrackSelectionRun3ITSMatch(cfgCustomTrackCuts.itsPattern);
LOG(info) << "Customizing track cuts:";
if (cfgCustomTrackCuts.tracksIU.value) {
Expand Down Expand Up @@ -1035,7 +1035,7 @@

bool isPhysicalPrimary(const o2::aod::McParticles::iterator& mcParticle)
{
if (maxProdRadius < 999.f) {

Check failure on line 1038 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if ((mcParticle.vx() * mcParticle.vx() + mcParticle.vy() * mcParticle.vy()) > maxProdRadius * maxProdRadius) {
return false;
}
Expand All @@ -1044,17 +1044,17 @@
}
bool isFinal(const o2::aod::McParticles::iterator& mcParticle)
{
if (!mcParticle.has_daughters() && !mcParticle.isPhysicalPrimary() && mcParticle.getProcess() == 4) {

Check failure on line 1047 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
auto mothers = mcParticle.mothers_as<o2::aod::McParticles>();
for (const auto& mother : mothers) {
if (!mother.isPhysicalPrimary() && mother.getProcess() == 4) {

Check failure on line 1050 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return true;
}
}
}
return false; // Otherwise, not considered a tertiary particle
}
template <int pdgSign, o2::track::PID::ID id>
template <int pdgSign, o2::track::PID::ID id, typename Colls>
void fillMCTrackHistograms(const TrackCandidatesMC::iterator& track, const bool doMakeHistograms)
{
static_assert(pdgSign == 0 || pdgSign == 1);
Expand All @@ -1073,8 +1073,8 @@
}
constexpr int histogramIndex = id + pdgSign * nSpecies;
LOG(debug) << "fillMCTrackHistograms for pdgSign '" << pdgSign << "' and id '" << static_cast<int>(id) << "' " << particleName(pdgSign, id) << " with index " << histogramIndex;
const o2::aod::McParticles::iterator& mcParticle = track.mcParticle();
const CollisionCandidatesMC::iterator& collision = track.collision_as<CollisionCandidatesMC>();
auto const& mcParticle = track.mcParticle();
auto const& collision = track.collision_as<Colls>();
float radius = std::sqrt(mcParticle.vx() * mcParticle.vx() + mcParticle.vy() * mcParticle.vy());
if (numSameCollision) {
if (!collision.has_mcCollision()) {
Expand Down Expand Up @@ -1167,7 +1167,7 @@
}
}
}
} else if (mcParticle.getProcess() == 4) { // Particle decay

Check failure on line 1170 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// Checking mothers
bool motherIsAccepted = true;
if (checkForMothers.value && mothersPDGs.value.size() > 0 && mcParticle.has_mothers()) {
Expand Down Expand Up @@ -1271,7 +1271,7 @@
hPtRadiusGeneratedPrm[histogramIndex]->Fill(mcParticle.pt(), radius);
}
} else {
if (mcParticle.getProcess() == 4) { // Particle decay

Check failure on line 1274 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
bool motherIsAccepted = true;
// Check for mothers if needed
if (checkForMothers.value && mothersPDGs.value.size() > 0 && mcParticle.has_mothers()) {
Expand Down Expand Up @@ -1452,7 +1452,7 @@
}
if (applyEvSel == 1 && !collision.sel7()) {
return false;
} else if (applyEvSel == 2 && !collision.sel8()) {

Check failure on line 1455 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
if constexpr (doFillHistograms) {
Expand Down Expand Up @@ -1550,7 +1550,7 @@

if (noFakesHits) { // Selecting tracks with no fake hits
bool hasFakeHit = false;
for (int i = 0; i < 10; i++) { // From ITS to TPC

Check failure on line 1553 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (track.mcMask() & 1 << i) {
hasFakeHit = true;
break;
Expand Down Expand Up @@ -1872,15 +1872,15 @@
// Filling variable histograms
histos.fill(HIST("MC/trackLength"), track.length());
static_for<0, 1>([&](auto pdgSign) {
fillMCTrackHistograms<pdgSign, o2::track::PID::Electron>(track, doEl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Muon>(track, doMu);
fillMCTrackHistograms<pdgSign, o2::track::PID::Pion>(track, doPi);
fillMCTrackHistograms<pdgSign, o2::track::PID::Kaon>(track, doKa);
fillMCTrackHistograms<pdgSign, o2::track::PID::Proton>(track, doPr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Deuteron>(track, doDe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Triton>(track, doTr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Helium3>(track, doHe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Alpha>(track, doAl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Electron, CollisionCandidatesMC>(track, doEl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Muon, CollisionCandidatesMC>(track, doMu);
fillMCTrackHistograms<pdgSign, o2::track::PID::Pion, CollisionCandidatesMC>(track, doPi);
fillMCTrackHistograms<pdgSign, o2::track::PID::Kaon, CollisionCandidatesMC>(track, doKa);
fillMCTrackHistograms<pdgSign, o2::track::PID::Proton, CollisionCandidatesMC>(track, doPr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Deuteron, CollisionCandidatesMC>(track, doDe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Triton, CollisionCandidatesMC>(track, doTr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Helium3, CollisionCandidatesMC>(track, doHe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Alpha, CollisionCandidatesMC>(track, doAl);
});
}

Expand Down Expand Up @@ -1963,7 +1963,7 @@
// Loop on particles to fill the denominator
float dNdEta = 0; // Multiplicity
for (const auto& mcParticle : groupedMcParticles) {
if (TMath::Abs(mcParticle.eta()) <= 2.f && !mcParticle.has_daughters()) {

Check failure on line 1966 in DPG/Tasks/AOTTrack/qaEfficiency.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
dNdEta += 1.f;
}
if (!isInAcceptance(mcParticle, HIST("MC/particleSelection"))) {
Expand Down Expand Up @@ -2041,15 +2041,15 @@
// Filling variable histograms
histos.fill(HIST("MC/trackLength"), track.length());
static_for<0, 1>([&](auto pdgSign) {
fillMCTrackHistograms<pdgSign, o2::track::PID::Electron>(track, doEl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Muon>(track, doMu);
fillMCTrackHistograms<pdgSign, o2::track::PID::Pion>(track, doPi);
fillMCTrackHistograms<pdgSign, o2::track::PID::Kaon>(track, doKa);
fillMCTrackHistograms<pdgSign, o2::track::PID::Proton>(track, doPr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Deuteron>(track, doDe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Triton>(track, doTr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Helium3>(track, doHe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Alpha>(track, doAl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Electron, o2::aod::Collisions>(track, doEl);
fillMCTrackHistograms<pdgSign, o2::track::PID::Muon, o2::aod::Collisions>(track, doMu);
fillMCTrackHistograms<pdgSign, o2::track::PID::Pion, o2::aod::Collisions>(track, doPi);
fillMCTrackHistograms<pdgSign, o2::track::PID::Kaon, o2::aod::Collisions>(track, doKa);
fillMCTrackHistograms<pdgSign, o2::track::PID::Proton, o2::aod::Collisions>(track, doPr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Deuteron, o2::aod::Collisions>(track, doDe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Triton, o2::aod::Collisions>(track, doTr);
fillMCTrackHistograms<pdgSign, o2::track::PID::Helium3, o2::aod::Collisions>(track, doHe);
fillMCTrackHistograms<pdgSign, o2::track::PID::Alpha, o2::aod::Collisions>(track, doAl);
});
}

Expand Down
Loading