Skip to content

Conversation

@njacazio
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

O2 linter results: ❌ 52 errors, ⚠️ 151 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add A3 geo provider [Common,ALICE3] Add A3 geo provider Dec 18, 2025
@njacazio njacazio marked this pull request as ready for review December 18, 2025 13:00
@njacazio njacazio enabled auto-merge (squash) December 18, 2025 13:00
@njacazio njacazio disabled auto-merge December 18, 2025 13:00
@njacazio njacazio enabled auto-merge (squash) December 18, 2025 13:00
@njacazio njacazio marked this pull request as draft December 18, 2025 13:09
auto-merge was automatically disabled December 18, 2025 13:09

Pull request was converted to draft

@njacazio
Copy link
Collaborator Author

needs #14276

@njacazio
Copy link
Collaborator Author

@jesgum discussin with @lhusova we believe it's better to provide the idx of the smearer at collision level. Also the configuration has now been provided with a geometry container. All geometries should be provided from configuration files available at runtime. The tracker for primaries is now the same as the one for the secondaries. The overlap between LUTs should be handled in the memory.

@njacazio njacazio force-pushed the nj-a3geo branch 2 times, most recently from ab9658e to deabeed Compare December 22, 2025 09:07
@github-actions github-actions bot removed the common label Dec 22, 2025
@njacazio njacazio force-pushed the nj-a3geo branch 2 times, most recently from 1c672c7 to 076e2ac Compare December 24, 2025 11:11
@njacazio njacazio changed the title [Common,ALICE3] Add A3 geo provider [ALICE3] Add A3 geo provider Dec 24, 2025
@njacazio njacazio changed the title [ALICE3] Add A3 geo provider [ALICE3] Use A3 geo provider in OTF Dec 24, 2025
@njacazio njacazio marked this pull request as ready for review December 24, 2025 16:56
@njacazio njacazio enabled auto-merge (squash) December 24, 2025 16:56
alibuild
alibuild previously approved these changes Dec 24, 2025
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 8d73ed2 at 2025-12-24 18:58:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 10bbab2 at 2025-12-24 20:32:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14272-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTrackerPid.cxx:437:15: error: unused variable 'nGeometries' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants