Skip to content

Conversation

@jackal1-66
Copy link
Collaborator

Particle was copied, not referenced, causing logging issue as reported here: https://its.cern.ch/jira/browse/O2-6485

@jackal1-66 jackal1-66 requested a review from a team as a code owner November 21, 2025 10:01
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alcaliva alcaliva enabled auto-merge (squash) November 21, 2025 10:12
auto nparticles = T::mParticles.size();
for (Int_t iparticle = 0; iparticle < nparticles; ++iparticle) {
auto particle = (TParticle)T::mParticles.at(iparticle);
const auto& particle = T::mParticles.at(iparticle);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good if it works... but I don't see where this should make a difference.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes a difference only in the log messages. By using the copy the Jpsi will have no daughters before and after the decay because we're not referring to the particle in the stack. By taking a reference instead we see that as expected the Jpsi has no daughters before decay (turned off by a cfg switch), but it does after.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I understand the difference in outcome but I don't understand why it should matter on the technical side. Clearly the copy constructor of TParticle must then be doing something weird.

@sawenzel sawenzel disabled auto-merge November 24, 2025 11:29
@sawenzel sawenzel merged commit 9197b2f into AliceO2Group:master Nov 24, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants