-
Notifications
You must be signed in to change notification settings - Fork 180
Update the injector to use rapidity instead of eta #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Crash seems unrelated to this PR. @ktf have you seen this error somewhere else recently? |
|
No, I have not seen it. Also keep in mind that the new version of ROOT is not merged, so effectively nothing changed there. |
|
This is quite curious. I tested the PR on lxplus and I don't get the error, however I fet other failures on three configurations: Could you have a look @BongHwi ? |
|
Thanks a lot @jackal1-66 for checking the detailed errors. |
|
Problem is actually somewhere else: #2174 |
|
Thanks @jackal1-66 for checking the error! |
|
CI is now green, it will be merged when someone from LF approves it |
|
Great, I've contacted PAG convener, but actually I used to merge it before without other approval I remember... |
We're suspecting the strange injection results may come from the injection scheme we're using.
So we would like to try to produce some injected MCs from the local grid submission with the rapidity property.
Accordingly, the injection script has been introduced and updated all related files.