Skip to content

Conversation

@BongHwi
Copy link
Contributor

@BongHwi BongHwi commented Aug 18, 2025

We're suspecting the strange injection results may come from the injection scheme we're using.

So we would like to try to produce some injected MCs from the local grid submission with the rapidity property.

Accordingly, the injection script has been introduced and updated all related files.

@BongHwi BongHwi requested a review from a team as a code owner August 18, 2025 08:54
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@jackal1-66
Copy link
Collaborator

871-/sw/slc9_x86-64/O2/daily-20251002-0000-local1/include/GPU/GPUCommonBitSet.h:97:3: warning: ambiguous expansion of macro 'ClassDefNV' [-Wambiguous-macro]
872-  ClassDefNV(bitset, 1);
873-  ^
874-/sw/slc9_x86-64/ROOT/v6-32-06-alice10-1/include/Rtypes.h:345:9: note: expanding this definition of 'ClassDefNV'
875-#define ClassDefNV(name,id)                          \
876-        ^
877-input_line_4:26:9: note: other definition of 'ClassDefNV'
878-#define ClassDefNV(name, id) \
879-        ^
880-
881: *** Break *** segmentation violation

Crash seems unrelated to this PR. @ktf have you seen this error somewhere else recently?

@ktf
Copy link
Member

ktf commented Oct 3, 2025

No, I have not seen it. Also keep in mind that the new version of ROOT is not merged, so effectively nothing changed there.

@jackal1-66
Copy link
Collaborator

This is quite curious. I tested the PR on lxplus and I don't get the error, however I fet other failures on three configurations:

Error found in log /tmp/mgiacalo/O2DPG/o2dpg_tests/generators/1_GeneratorLF_Resonances_pp1360_trigger.ini_External_dir/o2sim_serverlog
318- |  *------------------------------------------------------------------------------*  | 
319- |                                                                                    | 
320- *------------------------------------------------------------------------------------* 
321-
322-[16:45:25][INFO] GeneratorPythia8LFRapidity constructor
323-[16:45:25][INFO] ++ mOneInjectionPerEvent: 1
324-[16:45:25][INFO] ++ mGapBetweenInjection: 4
325-[16:45:25][INFO] ++ mUseTriggering: 0
326-[16:45:25][INFO] ++ pythiaCfgMb: 
327-[16:45:25][INFO] ++ pythiaCfgSignal: 
328:[16:45:25][FATAL] Configuration file provided for 'GeneratorPythia8' should be empty for this injection scheme
329:terminate called after throwing an instance of 'fair::FatalException'
Error found in log /tmp/mgiacalo/O2DPG/o2dpg_tests/generators/2_GeneratorLF_Resonances_PbPb5360_trigger.ini_External_dir/o2sim_serverlog
318- |  *------------------------------------------------------------------------------*  | 
319- |                                                                                    | 
320- *------------------------------------------------------------------------------------* 
321-
322-[16:46:36][INFO] GeneratorPythia8LFRapidity constructor
323-[16:46:36][INFO] ++ mOneInjectionPerEvent: 1
324-[16:46:36][INFO] ++ mGapBetweenInjection: 4
325-[16:46:36][INFO] ++ mUseTriggering: 0
326-[16:46:36][INFO] ++ pythiaCfgMb: 
327-[16:46:36][INFO] ++ pythiaCfgSignal: 
328:[16:46:36][FATAL] Configuration file provided for 'GeneratorPythia8' should be empty for this injection scheme
329:terminate called after throwing an instance of 'fair::FatalException'
Error found in log /tmp/mgiacalo/O2DPG/o2dpg_tests/generators/8_GeneratorLF_Resonances_pp900_trigger.ini_External_dir/o2sim_serverlog
318- |  *------------------------------------------------------------------------------*  | 
319- |                                                                                    | 
320- *------------------------------------------------------------------------------------* 
321-
322-[16:49:25][INFO] GeneratorPythia8LFRapidity constructor
323-[16:49:25][INFO] ++ mOneInjectionPerEvent: 1
324-[16:49:25][INFO] ++ mGapBetweenInjection: 4
325-[16:49:25][INFO] ++ mUseTriggering: 0
326-[16:49:25][INFO] ++ pythiaCfgMb: 
327-[16:49:25][INFO] ++ pythiaCfgSignal: 
328:[16:49:25][FATAL] Configuration file provided for 'GeneratorPythia8' should be empty for this injection scheme
329:terminate called after throwing an instance of 'fair::FatalException'

Could you have a look @BongHwi ?
@ktf the errors are even more confusing now in the CI:

�[0;31mError found in log /sw/BUILD/6f3cf4b016e0f03ebab3e1c157976f076e443ef0/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/0_GeneratorLF_ExoticResonances_pp1360.ini_External_dir/o2sim_serverlog�[0m
4703-  ClassDefOverride(o2::math_utils::Legendre2DPolynominal, 1);
4704-};
4705-
4706-} // namespace o2::math_utils
4707-
4708-#endif
4709-
4710-#undef  _BACKWARD_BACKWARD_WARNING_H
4711-
4712-
4713: *** Break *** segmentation violation
4714-
4715-
4716-
4717-========

@BongHwi
Copy link
Contributor Author

BongHwi commented Oct 16, 2025

Thanks a lot @jackal1-66 for checking the detailed errors.
I overlooked it since I tested the script only with the default injector.
Since we don't have a plan to test the triggered-production now, I removed them.

@jackal1-66
Copy link
Collaborator

jackal1-66 commented Oct 28, 2025

Problem is actually somewhere else: #2174
This PR should fix the issue and your tests should be successful. The problem is that at building time the include paths are not set so you're not able to include the nlohmann_json header file.

@BongHwi
Copy link
Contributor Author

BongHwi commented Oct 29, 2025

Thanks @jackal1-66 for checking the error!
Let's re-test this PR once the PR is merged.

@jackal1-66 jackal1-66 enabled auto-merge (squash) October 30, 2025 13:13
@jackal1-66
Copy link
Collaborator

CI is now green, it will be merged when someone from LF approves it

@BongHwi
Copy link
Contributor Author

BongHwi commented Oct 30, 2025

Great, I've contacted PAG convener, but actually I used to merge it before without other approval I remember...

@jackal1-66 jackal1-66 merged commit 0aa78f8 into AliceO2Group:master Oct 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants