Call ODC.EnsureStop in case that we go to ERROR #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
previously approved these changes
Aug 6, 2025
knopers8
changed the title
Collaborator
Author
|
Putting on hold until we get confirmation whether we should or should not call ODC STOP when a partition goes to ERROR. |
This commit needs a corresponding change in AliECS which adds a check for "RUNNING" state in Odc.EnsureStop before actually calling, so it is not done when inappropriate. Fixes OCTRL-1036
knopers8
changed the title
Collaborator
Author
We should. |
Collaborator
Author
|
@justonedev1 can you also have a look at this one? |
justonedev1
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit needs a corresponding change in AliECS which adds a check for "RUNNING" state in Odc.Stop before actually calling, so it is not done when inappropriate.
Fixes OCTRL-1036