readout-dataflow config-uri update #688
Conversation
| readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.ResolvePath('readout/' + run_type + '/any/readout-standalone-' + it)}}" | ||
| readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'any', 'readout-stfb-' + it)}}" | ||
| readout_cfg_uri_standalone: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, 'standalone', 'readout-standalone-' + it)}}" | ||
| readout_cfg_uri_stfb: "consul-ini://{{ consul_endpoint }}/o2/components/{{config.Resolve('readout', run_type, readout_folder, 'readout-stfb-' + it)}}" |
There was a problem hiding this comment.
could you add some correct and backwards-compatible default for readout_folder around here? Otherwise, the template might stop working for setups where we don't use readout_folder, e.g. openstack VMs.
There was a problem hiding this comment.
Ciao @knopers8 I did some tests and if I am not mistaken:
- if the folders do not exists in CONSUL
- if the variable is not set
it goes back toany
There was a problem hiding this comment.
this is the path of readout if I don't set anything
consul-ini://localhost:8500/o2/components/readout/ANY/any
There was a problem hiding this comment.
the only part where it fails if I don't set anything is the standalone cfg ... as the standalone path is hardcoded.
But then I am wondering if we use it at all or if we always run with DD enabled.
If we use standalone meaning readout without DD, I can put some protection
There was a problem hiding this comment.
You're right, it should indeed go back to any.
It's not very important, but I would propose to anyway list it in defaults, so it is clear what are the variables that the workflow template expects.
There was a problem hiding this comment.
But then I am wondering if we use it at all or if we always run with DD enabled.
I do run readout alone sometimes on my VM.
2 participants
I have updated the readout cfg-uri to access the config files in CONSUL