Skip to content

[OCTRL-1076]: Unusual number of goroutines in executor's eventloop #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 1 commit into from
Dec 12, 2025
Merged

[OCTRL-1076]: Unusual number of goroutines in executor's eventloop #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion executor/eventloop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ func eventLoop(state *internalState, decoder encoding.Decoder, h events.Handler)
case e := <-eventCh:
log.Trace("EVENT LOOP about to handle event")
err = h.HandleEvent(ctx, &e)
// if we get an error here we are stoping the eventloop before triggering another nextEventNotify
// so it won't get stuck on eventCh, errorCh
if err != nil {
break
}

// Spawn a goroutine to wait for the next event
go nextEventNotify(decoder, eventCh, errorCh)
Expand Down Expand Up @@ -100,7 +105,7 @@ func sendFailedTasks(state *internalState) {
delete(state.failedTasks, taskID)
// If there aren't any failed and active tasks, we request to shutdown the executor.
if len(state.failedTasks) == 0 && len(state.activeTasks) == 0 {
//Originally state.shouldQuit = true but we want to keep the executor running
// Originally state.shouldQuit = true but we want to keep the executor running
log.WithField("executorId", state.executor.ExecutorID).Info("task failure notified, no tasks present on executor")
}
}
Expand Down