Skip to content

Fix some codechecker violations #14936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Dec 24, 2025
Merged

Fix some codechecker violations #14936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Detectors/CPV/reconstruction/include/CPVReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace o2
namespace cpv
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CPV) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/CTP/reconstruction/include/CTPReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace o2
namespace ctp
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::CTP) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/EMCAL/reconstruction/include/EMCALReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace o2
namespace emcal
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::EMC) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/FIT/FDD/reconstruction/include/FDDReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace o2
namespace fdd
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FDD) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/FIT/FT0/reconstruction/include/FT0Reconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace o2
namespace ft0
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FT0) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/FIT/FV0/reconstruction/include/FV0Reconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace o2
namespace fv0
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::FV0) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTrackingWorkflow/study/src/DumpTracks.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ using TBracket = o2::math_utils::Bracketf_t;

using timeEst = o2::dataformats::TimeStampWithError<float, float>;

class DumpTracksSpec : public Task
class DumpTracksSpec final : public Task
{
public:
DumpTracksSpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useMC)
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTrackingWorkflow/study/src/SVStudy.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ using V0ID = o2::dataformats::V0Index;

using timeEst = o2::dataformats::TimeStampWithError<float, float>;

class SVStudySpec : public Task
class SVStudySpec final : public Task
{
public:
SVStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useTPCCl, bool useMC)
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTrackingWorkflow/study/src/TPCTrackStudy.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ using TBracket = o2::math_utils::Bracketf_t;

using timeEst = o2::dataformats::TimeStampWithError<float, float>;

class TPCTrackStudySpec : public Task
class TPCTrackStudySpec final : public Task
{
public:
TPCTrackStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, GTrackID::mask_t src, bool useMC)
Expand Down
2 changes: 1 addition & 1 deletion Detectors/GlobalTrackingWorkflow/study/src/TrackMCStudy.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ using TBracket = o2::math_utils::Bracketf_t;

using timeEst = o2::dataformats::TimeStampWithError<float, float>;

class TrackMCStudy : public Task
class TrackMCStudy final : public Task
{
public:
TrackMCStudy(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts, bool checkSV)
Expand Down
4 changes: 2 additions & 2 deletions Detectors/GlobalTrackingWorkflow/study/src/TrackingStudy.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ using TBracket = o2::math_utils::Bracketf_t;

using timeEst = o2::dataformats::TimeStampWithError<float, float>;

class TrackingStudySpec : public Task
class TrackingStudySpec final : public Task
{
public:
TrackingStudySpec(std::shared_ptr<DataRequest> dr, std::shared_ptr<o2::base::GRPGeomRequest> gr, GTrackID::mask_t src, bool useMC, const o2::tpc::CorrectionMapsLoaderGloOpts& sclOpts)
Expand Down Expand Up @@ -444,7 +444,7 @@ void TrackingStudySpec::process(o2::globaltracking::RecoContainer& recoData)
}
bool ambig = vid.isAmbiguous();
auto trc = recoData.getTrackParam(vid);
if (abs(trc.getEta()) > mMaxEta) {
if (fabs(trc.getEta()) > mMaxEta) {
continue;
}
if (iv < nv - 1 && is == GTrackID::TPC && tpcTr && !tpcTr->hasBothSidesClusters()) { // for unconstrained TPC tracks correct track Z
Expand Down
2 changes: 1 addition & 1 deletion Detectors/HMPID/reconstruction/include/HMPIDReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace o2
namespace hmpid
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::HMP) {}
Expand Down
1 change: 0 additions & 1 deletion Detectors/ITSMFT/ITS/QC/TestDataReaderWorkflow/src/TestDataReader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,6 @@ void TestDataReader::run(ProcessingContext& pc)

std::vector<string> TestDataReader::GetFName(std::string folder)
{

DIR* dirp;

char cstr[folder.size() + 1];
Expand Down
2 changes: 1 addition & 1 deletion Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace o2
namespace itsmft
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
using PMatrix = std::array<std::array<bool, ClusterPattern::MaxRowSpan + 2>, ClusterPattern::MaxColSpan + 2>;
Expand Down
2 changes: 1 addition & 1 deletion Detectors/MUON/MCH/CTF/include/MCHCTF/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace o2
namespace mch
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::MCH) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/MUON/MID/CTF/include/MIDCTF/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace o2
namespace mid
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::MID) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/PHOS/reconstruction/include/PHOSReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace o2
namespace phos
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::PHS) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/TOF/reconstruction/include/TOFReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace o2
namespace tof
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TOF) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/TPC/reconstruction/include/TPCReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ struct MergedColumnsDecoder {

} // namespace detail

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TPC) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/TRD/reconstruction/include/TRDReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace o2
namespace trd
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::TRD) {}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/ZDC/reconstruction/include/ZDCReconstruction/CTFCoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace o2
namespace zdc
{

class CTFCoder : public o2::ctf::CTFCoderBase
class CTFCoder final : public o2::ctf::CTFCoderBase
{
public:
CTFCoder(o2::ctf::CTFCoderBase::OpType op) : o2::ctf::CTFCoderBase(op, CTF::getNBlocks(), o2::detectors::DetID::ZDC) {}
Expand Down
2 changes: 1 addition & 1 deletion Framework/Utils/include/DPLUtils/RootTreeWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ class RootTreeWriter
impl.start = &(data[0]);
impl.end = &(data[data.size() - 1]) + 1; // end pointer (beyond last element)
impl.cap = impl.end;
std::memcpy(&v, &impl, sizeof(VecBase));
std::memcpy((void*)&v, (const void*)&impl, sizeof(VecBase));
};

// if the value type is messagable and has a ROOT dictionary, two serialization methods are possible
Expand Down