Skip to content

DCA Fitter GPU: Disable failing test, which was not active before and seems broken #14935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Dec 24, 2025
+33 −33
Merged

DCA Fitter GPU: Disable failing test, which was not active before and seems broken #14935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Common/DCAFitter/GPU/cuda/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ o2_add_library(DCAFitterCUDA
set_property(TARGET ${targetName} PROPERTY CUDA_SEPARABLE_COMPILATION ON)
# add_compile_options(-lineinfo)

o2_add_test(DCAFitterNCUDA
SOURCES test/testDCAFitterNGPU.cxx
PUBLIC_LINK_LIBRARIES O2::ReconstructionDataFormats
O2::DCAFitterCUDA
O2::DCAFitter
ROOT::Core
ROOT::Physics
COMPONENT_NAME gpu
LABELS vertexing
ENVIRONMENT O2_ROOT=${CMAKE_BINARY_DIR}/stage
VMCWORKDIR=${CMAKE_BINARY_DIR}/stage/${CMAKE_INSTALL_DATADIR})
#o2_add_test(DCAFitterNCUDA
# SOURCES test/testDCAFitterNGPU.cxx
# PUBLIC_LINK_LIBRARIES O2::ReconstructionDataFormats
# O2::DCAFitterCUDA
# O2::DCAFitter
# ROOT::Core
# ROOT::Physics
# COMPONENT_NAME gpu
# LABELS vertexing
# ENVIRONMENT O2_ROOT=${CMAKE_BINARY_DIR}/stage
# VMCWORKDIR=${CMAKE_BINARY_DIR}/stage/${CMAKE_INSTALL_DATADIR})
24 changes: 12 additions & 12 deletions Common/DCAFitter/GPU/hip/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ o2_add_hipified_library(DCAFitterHIP
PRIVATE_LINK_LIBRARIES O2::GPUTrackingHIPExternalProvider
TARGETVARNAME targetNAme)

o2_add_test(DCAFitterNHIP
SOURCES ../cuda/test/testDCAFitterNGPU.cxx
PUBLIC_LINK_LIBRARIES O2::ReconstructionDataFormats
O2::DCAFitterHIP
O2::DCAFitter
ROOT::Core
ROOT::Physics
HIPIFIED test
COMPONENT_NAME gpu
LABELS vertexing
ENVIRONMENT O2_ROOT=${CMAKE_BINARY_DIR}/stage
VMCWORKDIR=${CMAKE_BINARY_DIR}/stage/${CMAKE_INSTALL_DATADIR})
#o2_add_test(DCAFitterNHIP
# SOURCES ../cuda/test/testDCAFitterNGPU.cxx
# PUBLIC_LINK_LIBRARIES O2::ReconstructionDataFormats
# O2::DCAFitterHIP
# O2::DCAFitter
# ROOT::Core
# ROOT::Physics
# HIPIFIED test
# COMPONENT_NAME gpu
# LABELS vertexing
# ENVIRONMENT O2_ROOT=${CMAKE_BINARY_DIR}/stage
# VMCWORKDIR=${CMAKE_BINARY_DIR}/stage/${CMAKE_INSTALL_DATADIR})
20 changes: 10 additions & 10 deletions GPU/Common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@ if(ALIGPU_BUILD_TYPE STREQUAL "O2")
COMPONENT_NAME GPU
LABELS gpu)
endif()
if (HIP_ENABLED)
o2_add_test(SMatrixImpHIP NAME test_SMatrixImpHIP
SOURCES test/testSMatrixImp.cu
HIPIFIED test
PUBLIC_LINK_LIBRARIES O2::${MODULE}
O2::MathUtils
ROOT::Core
COMPONENT_NAME GPU
LABELS gpu)
endif()
# if (HIP_ENABLED)
# o2_add_test(SMatrixImpHIP NAME test_SMatrixImpHIP
# SOURCES test/testSMatrixImp.cu
# HIPIFIED test
# PUBLIC_LINK_LIBRARIES O2::${MODULE}
# O2::MathUtils
# ROOT::Core
# COMPONENT_NAME GPU
# LABELS gpu)
# endif()
endif()

install(FILES ${HDRS_INSTALL} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/GPU)