Skip to content

Update of TPC fast space charge correction with splines #14921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidrohr wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Update of TPC fast space charge correction with splines #14921

davidrohr wants to merge 24 commits into from
+2,833 −2,297

Conversation

@davidrohr
Copy link
Collaborator

@davidrohr davidrohr commented Dec 15, 2025

Rebased version of #14723

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Dec 15, 2025

Error while checking build/O2/fullCI_slc9 for dc97a9d at 2025-12-15 11:27:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14921-slc9_x86-64/0/GPU/GPUTracking/Merger/GPUTPCGMTrackParam.cxx:525:270: error: no matching function for call to 'o2::gpu::TPCFastTransform::convVertexTimeToZOffset(int32_t&, float&, const int32_t&) const'
ninja: build stopped: subcommand failed.

Full log here.

@davidrohr
Copy link
Collaborator Author

davidrohr commented Dec 24, 2025

Dataflow issue is independent, and compiles and runs on GPU, but should not be merged yet. Will comment more in the mail thread.

sgorbuno and others added 23 commits December 24, 2025 16:04
@sgorbuno @davidrohr
TPC Splines: fix initialization of the track residuals in the test macro
798df8d
@sgorbuno @davidrohr
TPC Splines: fix propagation of the track residual data to the TPC ro…
996c09d 
…w edges
@sgorbuno @davidrohr
TPC Splines: non-uniform grid that corresponds to the track residual …
9874971 
…voxels
@sgorbuno @davidrohr
TPC Splines: multithreaded reading of the residual tree
afb4e0e
@sgorbuno @davidrohr
TPC Splines: add limits for SP correction values per TPC row
50a7557
@sgorbuno @davidrohr
TPC Splines: disable smoothing
18f34dd
@davidrohr
TPC Splines: smooth to linear edges, crop at grid borders, use mean p…
2f00a48 
…osition of residuals
@sgorbuno @davidrohr
TPC Splines: fix the inverse correction
c8da284
@sgorbuno @davidrohr
TPC Splines: fix reading track residuals
1d69139
@sgorbuno @davidrohr
TPC Splines: fix scaling splines outside of the measured area
2469531
@sgorbuno @davidrohr
TPC Splines: rename Slice -> Roc in geometry
00b913d
@sgorbuno @davidrohr
TPC Splines: minimise the amount of transformations
57bfa41
@sgorbuno @davidrohr
TPC Splines: init inverse from the inverse voxel map; rebase
3ea668f
@sgorbuno @davidrohr
TPC Splines: cleanup
956826e
@sgorbuno @davidrohr
TPC Splines: fast merge of SC corrections
967c35f
@sgorbuno @davidrohr
TPC Splines: get rid of internal UV coordinates
a0155d4
@sgorbuno @davidrohr
TPC Splines: completely switch to local TPC coordinates in the grid
1029a37
@cbmsw @davidrohr
TPC Splines: correct biased voxels; features for debugging
b4da791
@cbmsw @davidrohr
TPC Splines: replace std::tuple by std::array
9a64980
@cbmsw @davidrohr
TPC Splines: better smoothing between the voxels
8c42bbe
@davidrohr
TPCFastTransform: fix compilation on GPU with the new splines
99171c3
@cbmsw @davidrohr
TPC Splines: bugfixes in spline merging
46a3efd
@cbmsw @davidrohr
TPC Splines: add backward compatibility
093a834
@cbmsw @davidrohr
Fix compiler-warnings, codechecker violations and compilation
4408af2 
Fix compiler warnings on MacOS

Fix compiler warning, memmove must only operate on trivial types

Fix coding rule violations

TPC Splines: compilation fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgorbuno sgorbuno Awaiting requested review from sgorbuno sgorbuno is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidrohr @alibuild @sgorbuno @cbmsw