Support for Thorlabs BSC20x, M30 Series, and KVS30 stages#111
Open
bhathawayQNT wants to merge 8 commits intoAlexShkarin:mainfrom
Open
Support for Thorlabs BSC20x, M30 Series, and KVS30 stages#111bhathawayQNT wants to merge 8 commits intoAlexShkarin:mainfrom
bhathawayQNT wants to merge 8 commits intoAlexShkarin:mainfrom
Conversation
Having SCC20. causes line 216 to fail if you have a SCC201 device. This is because "SCC20." is not a regex match for "SCC201"
Treats "|" as an actual OR symbol by iterating through the options entered in _device_SN
bhathawayQNT
changed the title
depreciated support for pkg_resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, the BSC20x series is detected by Kinesis as a SCC20x model. Because of this BSC20x tends not to load correctly (e.g. incorrect scaling factors, unrecognized model number, etc.). I've added a few minor changes to handle this. I have tested this with a BSC201 stage. Also adding scale values and support for M30 series and KVS30 (tested with both).