Removed memmap from verifier and contributor commands #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibaryshnikov
requested review from
apruden2008,
emmorais,
howardwu,
jules and
kellpossible
niklaslong
reviewed
Nov 17, 2021
niklaslong
left a comment
niklaslong
left a comment
There was a problem hiding this comment.
Seems like a desirable change at first glance 👍
@ibaryshnikov what's the status on those tests? Some of the existing ones don't seem to compile either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contribute,new_challengeandtransform_pok_and_correctnessfunctions of phase1-clipanic-controldependency from contributor. I'd like to propose failfast approach hereWith this change verifier and contributor will be processing files in memory, avoiding usage of file system. It aims to reduce the amount of errors and improve the stability of the setup.
The PR is ready for review, but don't merge it yet. I'd like to write a few tests to ensure that the behaviour of changed functions is identical to the old one.