#368 use fs-err for improved error messages #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellpossible
requested review from
apruden2008,
emmorais,
ibaryshnikov and
jules
kellpossible
assigned
kellpossible and unassigned
ibaryshnikov,
emmorais,
jules and
apruden2008
jules
force-pushed
the
simplify_storage
branch
from
7b71127 to
33ca464
Compare
jules
force-pushed
the
refactor/368-use-fs-err
branch
from
c91f4ba to
88c335c
Compare
jules
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368 refactor some key useages of
std::fsto usefs-errinstead for improved error messages.Please do not merge before #361
TODO: fix an error compiling unit tests