Open
Conversation
Owner
|
Hi @JohnCoene, love the idea. Haven't yet had time to take a look at the code. But I do want to do that within the next weeks. Promise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Albert,
Thanks for the package. I thought I would change the API to using R's S3 interface namely so that it is extensible; this PR enables anyone to add new vendors.
I know this is quite a large PR which changes a lot of the source code so I'd totally understand if you do not want to merge it.
The idea is that change
create_chatto a generic that returns an object of classtidychaton which we can then call various methods.I could for instance bring support for a new vendor via:
Either the existing methods to
add_message,add_param, etc. for the objecttidychatwork fine with my API in which case I can leave it as is. Otherwise I can create methods.