Use release 2.3.0 or earlier since 2.4.0 changes filenames and behavior significantly #14
Conversation
|
Nope, never mind, having the tempdir problem with this one too. Not sure why that's changed, though. Confusing. |
|
This does make the archive downloadable. So you'll want something like one of these PRs -- to use the naming from the most recent version or to use an older version that matches current naming. |
Default to release 2.3.0 since 2.4.0 changes filenames and behavior significantly So the env var won't work for version 2.4.0+.
noahgibbs
force-pushed
the
use_specific_release_version
branch
from
cab0298 to
90ca7a9
Compare
noahgibbs
changed the title
|
Okay, I think this is working. I updated the HTML template to use the correct browser.umd.js version as well -- which means we can't use this method of version control for 2.0.0 or before, because there's no browser.umd.js still available. But basically this works for switching 2.2.0/2.3.0 and (I think) 2.1.0. I still can't get scarpe-wasm working, though. Getting some kind of an out of bounds memory request VM error. |
|
You okay if I merge this? |
|
I should also add a patch for release filenames so that we can try with 2.4.0 and up. I assume as long as we're using outdated versions it's going to be hard to keep things working. |
|
Huh. And I haven't even considered the whole Ruby 3.3 angle. That may be related somehow? Hard to say. |
This is a much smaller change, and probably a good idea regardless. We can cache the file much more easily if we're using a known release. But 2.4.0 clearly changes some other significant things, like not (as far as I can tell) having a writable temp area. Locking to 2.3.0 fixes that.
I added a WASIFY_VERSION to set version 2.3.0 or earlier, defaulting to 2.3.0. It won't work for version 2.4.0 or later because of the change in filenames.
If you'd rather wasify always use latest, let me know and I can look at adding some kind of version config and scarpe-wasm can lock the version for itself without affecting wasify.