Replace ProtocolLib with PacketEvents integration #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from ProtocolLib to PacketEvents for packet handling, updating dependencies and code accordingly. Added PacketEventsManager, removed ProtocolLibManager, and refactored TitleAPI to use PacketEvents for title, tab, and action bar messages. Updated pom.xml dependencies and plugin.yml to depend on PacketEvents instead of ProtocolLib.
Author
Owner
|
Nice! But I can't add these to the plugin, mainly because:
|
Introduces a PacketManager interface and implements ProtocolLibManager and PacketEventsManager for handling tab completion blocking. The plugin now supports both ProtocolLib and PacketEvents, with a new 'packet_library' config option to select the preferred library or auto-detect. Updates plugin.yml dependencies, configuration, and refactors EasyCommandBlocker to use the new abstraction.
Author
|
New changes not tested. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from ProtocolLib to PacketEvents for packet handling, updating dependencies and code accordingly. Added PacketEventsManager, removed ProtocolLibManager, and refactored TitleAPI to use PacketEvents for title, tab, and action bar messages. Updated pom.xml dependencies and plugin.yml to depend on PacketEvents instead of ProtocolLib.