fix: fix security for actionsutils.java by adding keys #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took 24 minutes
|
There's no need to encrypt the message being sent as the packet can be intercepted at the proxy level, which is what Ajneb's current fix (pending to be pushed) is. |
Author
|
I am not encrypting the packet. Instead i added a key function. Plugins that use the channel then need to provide the key defined in the config to use the Action |
|
Still, the best way is to simply ignore it directly instead of relying in a secret. A fix has been pushed that does that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This is untested cuz i don't care..
Whoever wants to try do it but I don't know why this shouldn't work..
However this is the code.