Add support for nativegamesizing at game launch#147
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for native game sizing on Android by communicating the feature's availability to the AirConsole platform at game launch. The implementation uses a new runtime settings asset to persist the native game sizing configuration and updates the WebGL templates to conditionally handle game sizing logic based on this setting.
Key changes:
- Introduction of
AirconsoleRuntimeSettingsScriptableObject to persist native game sizing support configuration - Modified Android webview initialization to include native game sizing support in URL parameters
- Updated WebGL templates to conditionally execute sizing-related code based on
AIRCONSOLE_ANDROID_NATIVE_GAMESIZINGflag
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents the new native game sizing feature and related Android improvements |
| Assets/WebGLTemplates/AirConsole-U6/airconsole-unity-plugin.js | Updated to conditionally handle game sizing based on native support flag |
| Assets/WebGLTemplates/AirConsole-2020/airconsole-unity-plugin.js | Same conditional game sizing logic as U6 template, plus debug logging |
| Assets/AirConsole/scripts/Runtime/AirconsoleRuntimeSettings.cs | New ScriptableObject for runtime access to native game sizing setting |
| Assets/AirConsole/scripts/Runtime/AirConsole.cs | Modified to read runtime settings and pass native sizing support in webview URL |
| Assets/AirConsole/scripts/Editor/Inspector.cs | Extended to create/update runtime settings asset when native game sizing preference changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3249323 to
2b58430
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
No description provided.