Skip to content

Add support for nativegamesizing at game launch#147

Merged
marc-n-dream merged 3 commits intomasterfrom
PRO-1747-support-nativegamesizing
Nov 4, 2025
Merged

Add support for nativegamesizing at game launch#147
marc-n-dream merged 3 commits intomasterfrom
PRO-1747-support-nativegamesizing

Conversation

@marc-n-dream
Copy link
Collaborator

No description provided.

@marc-n-dream marc-n-dream requested a review from Copilot November 3, 2025 18:44
@marc-n-dream marc-n-dream added this to the v2.6.2 milestone Nov 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for native game sizing on Android by communicating the feature's availability to the AirConsole platform at game launch. The implementation uses a new runtime settings asset to persist the native game sizing configuration and updates the WebGL templates to conditionally handle game sizing logic based on this setting.

Key changes:

  • Introduction of AirconsoleRuntimeSettings ScriptableObject to persist native game sizing support configuration
  • Modified Android webview initialization to include native game sizing support in URL parameters
  • Updated WebGL templates to conditionally execute sizing-related code based on AIRCONSOLE_ANDROID_NATIVE_GAMESIZING flag

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CHANGELOG.md Documents the new native game sizing feature and related Android improvements
Assets/WebGLTemplates/AirConsole-U6/airconsole-unity-plugin.js Updated to conditionally handle game sizing based on native support flag
Assets/WebGLTemplates/AirConsole-2020/airconsole-unity-plugin.js Same conditional game sizing logic as U6 template, plus debug logging
Assets/AirConsole/scripts/Runtime/AirconsoleRuntimeSettings.cs New ScriptableObject for runtime access to native game sizing setting
Assets/AirConsole/scripts/Runtime/AirConsole.cs Modified to read runtime settings and pass native sizing support in webview URL
Assets/AirConsole/scripts/Editor/Inspector.cs Extended to create/update runtime settings asset when native game sizing preference changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marc-n-dream marc-n-dream force-pushed the PRO-1747-support-nativegamesizing branch from 3249323 to 2b58430 Compare November 3, 2025 18:45
@marc-n-dream
Copy link
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marc-n-dream marc-n-dream marked this pull request as ready for review November 4, 2025 10:50
@marc-n-dream marc-n-dream merged commit 2a32878 into master Nov 4, 2025
1 check passed
@marc-n-dream marc-n-dream deleted the PRO-1747-support-nativegamesizing branch November 4, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant