Migrate to astro #32
Migrate to astro #32
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f0c0cdfec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const patternRecords = await base("patterns") | ||
| .select({ view: "Grid view" }) | ||
| .all(); |
There was a problem hiding this comment.
This fetch pulls the entire patterns table with no language filter. The previous implementation scoped patterns by language code, so if the Airtable base contains multiple languages the Astro page will mix unrelated patterns and the nav order will be wrong. Consider passing a language code (or using a language-specific view/filter) when selecting records so the page stays consistent per language.
Useful? React with 👍 / 👎.
| problem: getString(fields, "problem"), | ||
| solution: getString(fields, "solution"), | ||
| significance: parseSignificance(getString(fields, "significance")), |
There was a problem hiding this comment.
The new code derives significance by calling getString and counting ⭐ characters. If the Airtable field is numeric (as implied by the previous Gatsby code that compared significance > 0 and looped to that number), getString returns null, parseSignificance yields 0, and no stars are rendered. Handle numeric significance as well (e.g., getNumber or accept both string/number) to avoid dropping ratings.
Useful? React with 👍 / 👎.
No description provided.